Skip to content

Return Transaction Id #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 24, 2025
Merged

Return Transaction Id #19

merged 10 commits into from
Sep 24, 2025

Conversation

codeismail-waver
Copy link
Contributor

Transaction id is nil in the payload returned to sdk integrators. This pr includes transaction id if it exists.

Before

  FlutterwaveDataResponse(
       txRef: txRef, 
       flwRef: flwRef, 
       deviceFingerprint: nil, 
       amount: amount, 
       chargedAmount: chargedAmount, 
       appFee: appFee,
       merchantFee: merchantFee, 
       processorResponse: processorResponse, 
       authModel: nil, 
       currency: currency, 
       ip: ip, 
       narration: narration, 
       status: status, 
       authURL:nil, 
       paymentType: nil, 
       fraudStatus: nil, 
       chargeType: nil, 
       createdAt: nil, 
       plan: nil, 
       id: nil, 
       accountID: nil, 
       customer: customer, card: nil)

After

  FlutterwaveDataResponse(
       txRef: txRef, 
       flwRef: flwRef, 
       deviceFingerprint: nil, 
       amount: amount, 
       chargedAmount: chargedAmount, 
       appFee: appFee,
       merchantFee: merchantFee, 
       processorResponse: processorResponse, 
       authModel: nil, 
       currency: currency, 
       ip: ip, 
       narration: narration, 
       status: status, 
       authURL:nil, 
       paymentType: nil, 
       fraudStatus: nil, 
       chargeType: nil, 
       createdAt: nil, 
       plan: nil, 
       id: id, //nullable id (returns id if it exist) 
       accountID: nil, 
       customer: customer, card: nil)

kpoose and others added 10 commits April 4, 2025 10:46
@kpoose
(FlutterwavePayViewController.swift): replaced forced unwrapping of t…
5b908c3 
…extfield.text with optional binding(if let)
@kpoose
(FlutterwavePayViewController.swift): replaced forced unwrapping of t…
c1f3855 
…extfield.text with optional binding
@kpoose
(FlutterwavePayViewController.swift): added safety check to avoid par…
9056521 
…tial data assignmeny
@kpoose
(FlutterwavePayViewController.swift): remove extra spaces
c893366
@corneliusyaovi
Merge pull request Flutterwave#16 from KposeFLW/bugfix/fix-textfield-…
06fdde3 
…exception-crash

Fix Crash Due To Unsafe TextField Iteration
@corneliusyaovi
Bumped version number
518771d
@corneliusyaovi
Merge pull request Flutterwave#17 from Flutterwave/dev
bc2ddcb 
Add security scan job to ci-cd workflow
@corneliusyaovi
Merge pull request Flutterwave#18 from Flutterwave/dev
783f458 
Update project name in security scan
@codeismail-waver
fix(mpesaverifymodel): include transaction id payload
0bca27b
@codeismail-waver
fix(pwbtverify): include transaction id payload
0eb1d72
@codeismail-waver codeismail-waver self-assigned this Sep 16, 2025
kpoose
kpoose reviewed Sep 16, 2025
View reviewed changes
Copy link
Contributor

@kpoose kpoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@codeismail-waver codeismail-waver mentioned this pull request Sep 16, 2025
Closed
@corneliusyaovi corneliusyaovi merged commit 39a7ee3 into Flutterwave:dev Sep 24, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpoose kpoose kpoose left review comments

@corneliusyaovi corneliusyaovi Awaiting requested review from corneliusyaovi

Assignees

@codeismail-waver codeismail-waver

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codeismail-waver @kpoose @corneliusyaovi